Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapJSONConvenience and mapBufferKeyToString do not work dues to faulty isBuffer check #209

Open
tw00 opened this issue Jan 20, 2022 · 0 comments

Comments

@tw00
Copy link

tw00 commented Jan 20, 2022

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch kafka-streams@5.0.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/kafka-streams/lib/dsl/StreamDSL.js b/node_modules/kafka-streams/lib/dsl/StreamDSL.js
index 730c871..94a2dd0 100644
--- a/node_modules/kafka-streams/lib/dsl/StreamDSL.js
+++ b/node_modules/kafka-streams/lib/dsl/StreamDSL.js
@@ -475,7 +475,7 @@ class StreamDSL {
                 return object;
             }
 
-            if (Buffer.isBuffer(object.key)) {
+            if (!Buffer.isBuffer(object.key)) {
                 return object;
             }
 

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant