Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when npm rebuild with node v7 #99

Open
shaunxu opened this issue Oct 26, 2016 · 9 comments
Open

Error when npm rebuild with node v7 #99

shaunxu opened this issue Oct 26, 2016 · 9 comments

Comments

@shaunxu
Copy link

shaunxu commented Oct 26, 2016

Upgrade to node v7 and execute npm rebuild in my project, then got error message said

Error: v8-profiler@5.6.5 install: `node-pre-gyp install --fallback-to-build`

Two errors reported

../src/heap_snapshot.cc:46:46: error: no member named 'GetHiddenValue' in 'v8::Object'
      info.GetReturnValue().Set(info.This()->GetHiddenValue(__root));
                                ~~~~~~~~~~~  ^
../src/heap_snapshot.cc:50:20: error: no member named 'SetHiddenValue' in 'v8::Object'
      info.This()->SetHiddenValue(__root, _root);
      ~~~~~~~~~~~  ^
2 errors generated.
@bonesoul
Copy link

same here

@pmurias
Copy link

pmurias commented Nov 18, 2016

PR #96 solves the issue.

@helio-frota
Copy link

Hi folks,
Any updates ?

We have a good tool that generates flamegraph and do some profiling things, and that tool is using v8-profiler, and we can't test against Node.js 7x yet :/

thanks.

@megastef
Copy link

megastef commented Dec 21, 2016

Is this published to NPM? I've got the same problem on node 7.3.0

@bonesoul
Copy link

bonesoul commented Jan 5, 2017

Same with 7.4.0 too.

@bompus
Copy link

bompus commented Jan 10, 2017

Just checking in to see if this package is going to be updated for node v7+ or taken over by somebody else?

@pkoretic
Copy link

pkoretic commented Feb 7, 2017

I'm also interested why has it stopped and what the future holds @3y3 @bajtos ?

@helio-frota
Copy link

I'm using this for now:
#96 (comment)

@hustxiaoc
Copy link
Collaborator

Please try v8-profiler@5.7.0 , should work now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants