Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node 10 #123

Open
roberttod opened this issue Apr 25, 2018 · 3 comments
Open

Support node 10 #123

roberttod opened this issue Apr 25, 2018 · 3 comments

Comments

@roberttod
Copy link

roberttod commented Apr 25, 2018

v8::TryCatch has been removed in the v8 engine shipped with node 10 so node-pre-gyp fails in the compilation step. Not sure what the alternative is, but below is the line of code causing the issue. Seems like it would be a fairly simple fix (to someone more intimate with v8 than I am).

https://github.com/node-inspector/v8-profiler/blob/master/src/heap_profiler.cc#L16

@hyj1991
Copy link

hyj1991 commented May 29, 2018

change v8::TryCatch to Nan::TryCatch will be ok

@tlhunter
Copy link

tlhunter commented Mar 8, 2019

Other errors will appear after applying @hyj1991's suggestion:

../src/heap_graph_node.cc:69:24: error: no matching function for call to ‘v8::Object::Has(int32_t&)’

@hyj1991
Copy link

hyj1991 commented Mar 8, 2019

@tlhunter

src/heap_graph_node.cc:69: change if (_cache->Has(_id)) { to if (_cache->Has(Nan::New<Number>(_id))) {

also you can try v8-profiler-next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants