Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v7.x seems to be unsupported #32

Open
ignasg opened this issue Nov 23, 2016 · 7 comments
Open

Node v7.x seems to be unsupported #32

ignasg opened this issue Nov 23, 2016 · 7 comments

Comments

@ignasg
Copy link

ignasg commented Nov 23, 2016

Generates the following build errors:

..\src\debug.cc(38): error C2660: 'v8::Debug::Call' : function does not take 1
arguments [\node_modules\v8-debug\build\debug.vcxproj]
..\src\debug.cc(46): error C2660: 'v8::Debug::GetDebugContext' : function does
not take 0 arguments [\node_modules\v8-debug\build\debug.vcxproj]
..\src\debug.cc(46): error C2227: left of '->GetIsolate' must point to class/st
ruct/union/generic type [\node_modules\v8-debug\build\debug.vcxproj]
..\src\debug.cc(61): error C2660: 'v8::Debug::GetDebugContext' : function does
not take 0 arguments [\node_modules\v8-debug\build\debug.vcxproj]
..\src\debug.cc(66): error C2660: 'v8::Debug::GetDebugContext' : function does
not take 0 arguments [\node_modules\v8-debug\build\debug.vcxproj]
@ignasg
Copy link
Author

ignasg commented Nov 23, 2016

Was not able to figure out how to fix the source.
Downgrading to v6 seems to fix it

@kimbaudi
Copy link

I was able to use Node v.7x without downgrading by removing "node-inspection" npm package from package.json and using node-gyp, which I believe is already built into Node v6.3 or higher. Just don't use node-inspection. You can optionally npm install node-gyp -g, but I didn't have to.

@ignasg
Copy link
Author

ignasg commented Nov 24, 2016

If you avoid node-inspection it means you are not installing v8-debug, which defeats the purpose of installing v8-debug

@kimbaudi
Copy link

Sorry for misunderstanding the issue. If you need v8-debug, you're right to downgrade to v6 until it is fixed/supported in v7. The built in node.js debugger has an experimental v8 debugger: V8 Inspector Integration for Node.js.

@ballPointPenguin
Copy link

A list of supported Node versions in the README would be very helpful.

@bnoordhuis
Copy link

FWIW, v8::Debug::GetContext() will go away completely in node 9 or 10, see nodejs/CTC#62 (comment). It will have to be ported to the new v8_inspector API before Q1 or Q2 2018.

cc @bajtos - might be relevant to your interests.

@hustxiaoc
Copy link
Collaborator

It does support now, please try v8-debug@1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants