Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Debugger: Please implement search in all source files #234

Closed
gabrielschulhof opened this issue Oct 21, 2013 · 12 comments
Closed

Comments

@gabrielschulhof
Copy link

When you debug an application with node version 0.10.20 and node-inspector 0.5.0, and you press Ctrl+Shift+F to search in all files, after entering the search string and pressing Enter, you get a string of errors such as the following:

Debugger.searchInContent failed.
Error: Not implemented.
Debugger.searchInContent failed.
Error: Not implemented.
...
Page.searchInResource failed.
Error: Not implemented.
Page.searchInResource failed.
Error: Not implemented.
...

The fact that the Debugger object is the one that does not implement the functions lead me to not be sure if this pertains to node-inspector or to node itself. I'll file an issue against node as well, in case node-inspector has its part implemented.

@gabrielschulhof
Copy link
Author

Here's the node issue: nodejs/node-v0.x-archive#6388

@bajtos
Copy link
Member

bajtos commented Oct 23, 2013

This is a missing feature of Node Inspector, it has nothing to do with Node.js core. I am afraid I won't have bandwidth to implement it any time soon.

@bajtos
Copy link
Member

bajtos commented Dec 18, 2014

I am closing this issue, since there was not enough people asking for this enhancement. We can reopen it again later when there is more demand and/or there is a person willing to contribute the implementation.

@bajtos bajtos closed this as completed Dec 18, 2014
@francisbyrne
Copy link

I'd definitely find this useful.

@marcominetti
Copy link
Contributor

Hi @bajtos, I can definitely implement it in my weekends. 👍

@yoshiokatsuneo
Copy link

@marcominetti Is this already implemented ? I'm getting the same error message.

@marcominetti
Copy link
Contributor

@yoshiokatsuneo yep but it's not yet landed in master branch... You can try it from pr #621...

@yoshiokatsuneo
Copy link

@marcominetti Ah, I see. I'm looking forward to be merged to master.

@a7madgamal
Copy link

yesssss we need this!

@alex-georgiou
Copy link

Very useful feature. Please merge...

@johnreitano
Copy link

I definitely need this feature. Please merge!

@kristopolous
Copy link

I'll second this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants