Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with PHP 7.4 and the solution #17

Open
gabrielssevero opened this issue Sep 10, 2020 · 0 comments
Open

Problem with PHP 7.4 and the solution #17

gabrielssevero opened this issue Sep 10, 2020 · 0 comments

Comments

@gabrielssevero
Copy link

There is a problem of compatibility with php 7.4, it is in the file: plugins\dmitrybykov\htmlminify\vendor\matthiasmullie\minify\src\CSS.php

The problem is in the line 528 in the implode, in php 7.4 you need to change the position of the glue element and the array, so change: '/(?<=[: ])('.implode(array_keys($colors), '|').')(?=[; }])/i',
for: '/(?<=[: ])('.implode('|', array_keys($colors)).')(?=[; }])/i',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant