Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hysplit combine_dataset bugs #168

Open
amcz opened this issue Apr 4, 2024 · 3 comments
Open

hysplit combine_dataset bugs #168

amcz opened this issue Apr 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@amcz
Copy link
Collaborator

amcz commented Apr 4, 2024

combine_dataset function in hysplit.py has a couple bugs.

  1. It does not properly combine datasets in which the time coordinates are not the same. In the hysplit DataArrays the time coordinate are datetime64 objects. The xarray align method does not seem to be able to align these properly. The fix is to change the time coordinate to integers before aligning and then convert back to datetime objects after the datasets are merged.

  2. It also is not properly combining datasets when both the source and ensemble dimensions are greater than 1. Most use cases have focused on when we are looking at a source term ensemble with one meteorological dataset (source dimension > 1 and ens dimension=1) or a meteorological ensemble (source dimension=1 and ensemble dimension > 1). However it should also be able to produce a combined dataset when both these dimensions > 1.

@amcz amcz added bug Something isn't working enhancement New feature or request labels Apr 4, 2024
@amcz amcz self-assigned this Apr 4, 2024
@amcz
Copy link
Collaborator Author

amcz commented Apr 4, 2024

this issue has been fixed in hysplitdev branch

@zmoon
Copy link
Member

zmoon commented Apr 4, 2024

this issue has been fixed in hysplitdev branch

Cool, shall we PR to develop branch? Is the hysplit_experimental supposed to be included?

@amcz
Copy link
Collaborator Author

amcz commented Apr 17, 2024

Thanks - I will take the hysplit_experimental out and then it will be ready

@amcz amcz mentioned this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants