Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas v2 #111

Open
zmoon opened this issue Apr 20, 2023 · 4 comments
Open

pandas v2 #111

zmoon opened this issue Apr 20, 2023 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@zmoon
Copy link
Member

zmoon commented Apr 20, 2023

Some tests failing with pandas v2, noticed first in #110

=========================== short test summary info ============================
FAILED tests/test_airnow.py::test_add_data_hourly - assert 0 >= 1
 +  where 0 = RangeIndex(start=0, stop=0, step=1).size
 +    where RangeIndex(start=0, stop=0, step=1) = Empty DataFrame\nColumns: [time, siteid, site, utcoffset, time_local, latitude, longitude, cmsa_name, msa_code, msa_name, state_name, epa_region]\nIndex: [].index
FAILED tests/test_airnow.py::test_add_data_daily - assert 0 >= 1
 +  where 0 = RangeIndex(start=0, stop=0, step=1).size
 +    where RangeIndex(start=0, stop=0, step=1) = Empty DataFrame\nColumns: [time, siteid, site, latitude, longitude, cmsa_name, msa_code, msa_name, state_name, epa_region]\nIndex: [].index
FAILED tests/test_aeronet.py::test_serial_freq - TypeError: Could not convert lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15lev15 to numeric
FAILED tests/test_ish.py::test_ish_one_site[False] - TypeError: Could not convert FM-15FM-15FM-15 to numeric
FAILED tests/test_ish.py::test_ish_one_site[True] - TypeError: Could not convert FM-15FM-15FM-15 to numeric
FAILED tests/test_ish_lite.py::test_ish_lite_resample - ValueError: cannot insert siteid, already exists
FAILED tests/test_ish.py::test_ish_resample - TypeError: Could not convert FM-15FM-15FM-15FM-15FM-15FM-15FM-15FM-15FM-15 to numeric
============ 7 failed, 54 passed, 2 skipped, 57 warnings in 39.29s =============
@zmoon zmoon added the bug Something isn't working label Apr 20, 2023
@zmoon
Copy link
Member Author

zmoon commented Apr 20, 2023

For these tests, can mark and test with both pandas v1 and v2 to make sure changes don't break pandas v1 compat.

Would be nice to be able to check that results are the same too, easiest way would be to store the v1 results

@zmoon
Copy link
Member Author

zmoon commented Apr 24, 2023

Scheduled CI failed today due to this.

@zmoon zmoon pinned this issue May 9, 2023
@zmoon zmoon added this to the v0.3 milestone May 10, 2023
@zmoon
Copy link
Member Author

zmoon commented Sep 8, 2023

Looks like OpenAQ also needs some work to support pandas v2. @jordanschnell reported:

... @?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?T@?~U?

AssertionError

Which seems to come from this line:

 assert (
      zzz[~zzz.parameter.isin(["pm25", "pm4", "pm10", "bc"])].unit.dropna() == "ppm"
   ).all()

and needing to update the deprecated json_normalize call.

@zmoon
Copy link
Member Author

zmoon commented Sep 8, 2023

Note
Note that the conda-forge recipe doesn't currently restrict the pandas version. Nor does the install_requires. So you need to specify when creating your environment or downgrade if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant