Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing growth patterns #25

Open
k-doering-NOAA opened this issue Apr 26, 2022 · 6 comments
Open

add missing growth patterns #25

k-doering-NOAA opened this issue Apr 26, 2022 · 6 comments

Comments

@k-doering-NOAA
Copy link
Contributor

2, 3, 4, 5 are not represented.

@Rick-Methot-NOAA
Copy link
Collaborator

I think it makes sense to have collection of variants off of simple for each NatMort type and each growth type. Is that what you meant by growth pattern:
0 #_natM_type:_0=1Parm; 1=N_breakpoints; _2=Lorenzen; _3=agespecific; _4=agespec_withseasinterpolate; _5=BETA:_Maunder_link_to_maturity
#_no additional input for selected M option; read 1P per morph

1 # GrowthModel: 1=vonBert with L1&L2; 2=Richards with L1&L2; 3=age_specific_K_incr; 4=age_specific_K_decr; 5=age_specific_K_each; 6=NA; 7=NA; 8=growth cessation

@k-doering-NOAA
Copy link
Contributor Author

Yes, Exactly! I was looking through the current test set and seeing what was not represented.

Another option besides making the version of simple is seeing if we can change an existing model that is already being run and runs quickly. That way, we make the model set more orthogonal, rather than having simple with all the same features but just 1 difference in MG options.

@Rick-Methot-NOAA
Copy link
Collaborator

With the approach I suggested, it would be more like a unit test of growth (or of all biology) that is run on request if the code change is anything in ss_biofxn.tpl. A similar type of test could run all selectivity options if there is any change in ss_selex.tpl.

@k-doering-NOAA
Copy link
Contributor Author

Hmm, that does make some sense. We could of course do both approaches, as I'm not sure which one will pan out to be easier. The unit test one sounds like it would take more time to me, but maybe I am overthinking it.

@Rick-Methot-NOAA
Copy link
Collaborator

Any "simple" run is rather quick. So, I was thinking that the unit test runs I sketched would be an additional gha that is only invoked if certain files are changed.

@k-doering-NOAA
Copy link
Contributor Author

Thanks, Rick, I think we are on the same page!

By "take more time", I meant time to develop - I agree the simple runs will run quick once they are set up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants