Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guidance on implications of "addtocomp" values #214

Closed
iantaylor-NOAA opened this issue Jan 29, 2024 · 3 comments
Closed

add guidance on implications of "addtocomp" values #214

iantaylor-NOAA opened this issue Jan 29, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation Priority: Low

Comments

@iantaylor-NOAA
Copy link
Contributor

"Can we provide some guidance in documentation on implications of how much bigger than >0 they should use?"

Originally posted by @Rick-Methot-NOAA in nmfs-ost/ss3-source-code#555 (review)

The current documentation (section 7.14.0.2 "Added Constant to Proportions") says "Constant added to observed and expected proportions at length and age to make logL calculations more robust. Tail compression occurs before adding this constant. Proportions are renormalized to sum to 1.0 after constant is added."

Here's a potential addition: "The constant should be greater than 0. Commonly used values range from 0.00001 to 0.01. Larger values will cause differences among bins with smaller values to be less influential, leading to greater relative influence of the bins with largest proportions of the compositions."

@Rick-Methot-NOAA, do you have additions or revisions to that change?

Also, I see that section "7.16.3 Age Composition Specification" says "If age data are included in the model, the following set-up is required, similar to the length data section." I think we should change the last part of that sentence to something like "See Length Composition Data Structure [with hyperlink] for details on each of these inputs."

@iantaylor-NOAA iantaylor-NOAA added documentation Improvements or additions to documentation Priority: Low labels Jan 29, 2024
@iantaylor-NOAA
Copy link
Contributor Author

I should note that I've used 0.001 in the most recent assessments that I've worked on. The example table in the User Manual has 0.0001. Perhaps suggesting a single value (either of these would be fine) would be more helpful than providing a range of commonly used values.

@Rick-Methot-NOAA
Copy link
Collaborator

Is there any discussion on this topic in FIMS development?
Would be great to pick a model with noisy comp data and run a profile to demo influence of the add_to.
In addition to age and length, the same applies to generalized size comp.

@iantaylor-NOAA
Copy link
Contributor Author

This issue has not yet been addressed for FIMS. I agree that a profile over this value would be good to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Priority: Low
Projects
None yet
Development

No branches or pull requests

3 participants