Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muting a like can also mute a comment? #45

Open
michaelyhma opened this issue Oct 14, 2022 · 6 comments
Open

Muting a like can also mute a comment? #45

michaelyhma opened this issue Oct 14, 2022 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@michaelyhma
Copy link

This is an AMAZING extension - thank you for building this, Noah! Will definitely be buying you a kofi!

To Reproduce
Steps to reproduce the behavior:

  1. Go to LinkedIn
  2. Go to the feed
  3. You'll see some posts where a contact has both liked AND commented on a post
  4. The post is therefore muted

Expected behavior
Using your extension, there's a toggle to mute Likes - so this is correct. However, I did NOT mute Comments, so would have expected to see Comment, even if Likes were muted

Environment (please complete the following information):

  • Windows 10
  • Chrome
  • Should be the latest
@dirkhh
Copy link

dirkhh commented Oct 17, 2022

I had the same experience and agree with the "expected behavior"

@njelich
Copy link
Owner

njelich commented Oct 18, 2022

If they liked and commented they are gonna get caught by the like flag, and the current detectors are additive - meaning that it only takes one criteria to mute.

@michaelyhma
Copy link
Author

Understood! I guess the more specific feedback then would be:
"Would be perfect if the flags weren't additive" <3

@michaelyhma
Copy link
Author

I continue to use Link-Off, but the additive nature is muting, basically, everything (lol, also shows how LinkedIn Feed is a mess). Making the flag non-additive would make Link-Off super useful as a productivity/utility extension. Right now, it functions more as a "quiet"/"peaceful"/"zen"/"muting" extension.

@michaelyhma
Copy link
Author

Thank you for your consideration, Noah!

@njelich
Copy link
Owner

njelich commented Oct 26, 2022

If you want to implement it, I'll gladly merge the PR - should be simple:

  • The filtering is done here using keywords.some function.
  • This functionality could be made by making replacing the .some with a reducer counting the matches, and treating is as true only if there is exactly one match

@njelich njelich added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants