Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog position in FF #38

Open
psined1 opened this issue Jul 12, 2018 · 5 comments
Open

Dialog position in FF #38

psined1 opened this issue Jul 12, 2018 · 5 comments

Comments

@psined1
Copy link

psined1 commented Jul 12, 2018

Unlike Chrome, where the dialog is perfectly centered across the screen horizontally and vertically, in FireFox, the dialog is pushed all the way down underneath the page content, so, at times, it falls outside of the page viewable area.

Can this be improved by some CSS maybe?

Also, unlike Chrome, the dialog in FF is not modal at all. It allows user interact with other controls on the form, so dialog essentially acts nothing short of a div element. Sounds like dialog suffers from sheer implementation lackluster in FF.

@niutech
Copy link
Owner

niutech commented Jul 12, 2018

You have to set dom.dialog_element.enabled to true in about:config to enable <dialog> element or use a polyfill.

@niutech niutech closed this as completed Jul 12, 2018
@psined1
Copy link
Author

psined1 commented Jul 13, 2018

Yes, already did. That took care of dialog DOM support. Alas, it offers little help to my issue...

@niutech niutech reopened this Jul 13, 2018
@psined1
Copy link
Author

psined1 commented Jul 13, 2018

Worse yet, because FF dialog is not modal, it is possible to invoke the dialog more than once. Although this still results in one and only visible dialog on the screen, it is not possible to close the dialog without refreshing the page anymore. Demo page tested with FF for Mac 61.0.1 and FF for Windows 61.0.1 -

  1. click either button for the dialog to show, the dialog shows up, "Dialog argments: some argument"
  2. click once more either button for the dialog to show, this time with "Dialog argments: undefined"
  3. Attempt to close the dialog, nothing happens
  4. Refresh the page to start over

@niutech
Copy link
Owner

niutech commented Jul 17, 2018 via email

@psined1
Copy link
Author

psined1 commented Jul 19, 2018

Thanks. Did that. Still the behavior is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants