Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept header handling is still incorrect #676

Open
zmeggyesi opened this issue Oct 13, 2019 · 1 comment
Open

Accept header handling is still incorrect #676

zmeggyesi opened this issue Oct 13, 2019 · 1 comment

Comments

@zmeggyesi
Copy link
Contributor

Following in the footsteps of #673, and referring to #487 and #488, I think the Accept header's handling should be refined further to return a 406 Not Acceptable response, instead of falling back to text/html, as dictated by RFC7231.
I realise, however, that this is a breaking change, even if made strictly opt-in via a configuration parameter.

What are the thoughts in the community on this? Would it be worth sinking some time into it, or is the current algorithm "good enough"?

@raphaelbauer
Copy link
Contributor

I have no particular opinion :) For the services I am creating I never had to deal with super fine-grained accept headers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants