Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast Refresh #132

Open
shuding opened this issue Aug 30, 2022 · 1 comment
Open

Fast Refresh #132

shuding opened this issue Aug 30, 2022 · 1 comment

Comments

@shuding
Copy link

shuding commented Aug 30, 2022

Would be great to support HMR via React Fast Refresh. The official one was implemented as a Babel plugin so might be a bit tricky.
@nihgwu
Copy link
Owner

nihgwu commented Aug 30, 2022

@shuding yes, but I think live editing is mainly target to prod env where you can't use HMR, so I think it's fine, locally I use a separate package for live editing and persist the state in url, so my edits won't get lost, actually we can use babel-standalone as well for react-runner which also provide better error message by redirecting sucrase to babel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nihgwu @shuding