Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double Entries in nightscout, when deleting and reentering Treatments in AAPS #8213

Open
gerison77 opened this issue Jan 19, 2024 · 8 comments

Comments

@gerison77
Copy link

I have NS 15.0.2 running with using AAPSclient V 3.0. with NSClilent V1 due to parental setup, with 3 clients.

Bug:
Deleting Treatments (eg. carbs due to false timeshift) an reentering (at the intended point of time) leads to double entires in NS.
In the following example time shift was set incorrectly in the bolus calculator. The kh entry was then deleted and rentered (17g).
However. NS shows now double entries of the 17g. No Double entries in each AAPS App

Screenshots:

Build:
Screenshot_20240119-094121

Nighscout Web:

grafik

Treatments in AAPS Client:

Screenshot_20240113-094101~2

@psonnera
Copy link

I might be wrong but I don't thinks AAPS will delete tratments in NS. That should be done manually.

@gerison77
Copy link
Author

I really don't think so. It happend just again. A caretaker corrected carbs due to eating more than expected. Again double entries in NightScout. I surveill the data on my desk... the data should be correct, since they show up in nightscout reporter as well. So I have to desagree.

actual screenshots:
Screenshot_20240119-122157
grafik

@psonnera
Copy link

Can you please show the logs of AAPS sending the treatment deletion request to Nightscout?

@gerison77
Copy link
Author

gerison77 commented Jan 21, 2024

Hi I recreated the bug once again. Made new screenshots and log entry as follows.
I entered the carbs in AAPSClient and deleted them with AAPS Full. Whereas in the treatment tab of both AAPSClient and AAPSFull the entry was deleted (See Time of Screenshot 20:20, you have entries in NS Site. I entered 20g (20:17) and 25g (20:18) and deleted them both afterwards. See Screenshots. The same happened today when deleting ecarbs....

Screenshot_20240121-202045
Screenshot_20240121-202029

@gerison77
Copy link
Author

Were the logs submitted? I pasted them several times.....

@psonnera
Copy link

@gerison77 I don't see AAPS deleting treatments in Nightscout for neither V1 nor V3 API but I might be wrong. My question was: where did you read that this is an AAPS/NSClient feature, and if it is, can you show the request to Nightscout that's been ignored? It should show in the logs as a REST command DELETE /treatments.

@gerison77
Copy link
Author

gerison77 commented Jan 22, 2024

@psonnera Sorry Patrick, I didn't read that. I simply expected the data to be correct across all the platforms used. I posted this already on discord before and decided then to open this issue. If I was wrong, I am sorry. But since this is a security issue (you can bolus in a parental setup via SMS without involvement of AAPS Client - relying on NS could be missleading and cause false treatments.) I will take this issue to the proper channel than. Thank you for your time and effort.

@psonnera
Copy link

@gerison77 no excuses needed, I just wanted to make sure this was a documented feature before asking NS devs to act on it. Let's see the answer on AAPS side first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants