Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist: xterm 256 color support #67

Open
perlun opened this issue Nov 5, 2018 · 2 comments
Open

Wishlist: xterm 256 color support #67

perlun opened this issue Nov 5, 2018 · 2 comments
Labels

Comments

@perlun
Copy link

perlun commented Nov 5, 2018

Hi,

Thanks for a nice tool! 馃憤 I discovered it today since I wanted to get better outputs from tailing my Tomcat & application logs.

One thing I noted that seems to be missing from the feature matrix which would be incredibly nice is to be able to use 8-bit colors. They are supported by some of the modern terminal emulators - very nice since it gives a much larger amount of colors to select from.

The Ruby library which funnily is your namesake https://github.com/sickill/rainbow has this. Its implementation is particularly interesting, since it allows you to enter an RGB value (say #FF00FF) which will then be automatically converted to the closest 8-bit color code.

That makes the tool incredibly nice to use, but is obviously a bit more work. Just being able to specify these extended ANSI escape codes would be a good start in this area.

@nicoulaj
Copy link
Owner

nicoulaj commented Nov 5, 2018

Indeed, and some terminals even support true color.

The difficulty here is more to define a usable config syntax. One intermediate step I could see is to introduce support for color themes, so that user can replace the default 8 colors (black, white, red, green, yellow, blue, magenta, cyan) with 8/24 bit ones. But that would still be limited to 8 colors.

Related: #2

@perlun
Copy link
Author

perlun commented Nov 5, 2018

The difficulty here is more to define a usable config syntax

I agree, right now the syntax is pretty much connected to the ANSI 3/4-bit colors so this is a bit of a change from that perspective.

Maybe something like this would do:

[filters]
faint: ^[A-Z][a-z]+\s\d+,\s\d+\s\d+:\d+:\d+|^\d+\s[a-z]+\s\d+\s\d+:\d+:\d+
FF0000: ^GRAVE:\s.*|^SEVERE:\s.*
FFFF00: ^ATTENTION:\s.*|^WARNING:\s.*

(Can't really prefix them with # since we use that for commenting. 馃槉)

@nicoulaj nicoulaj mentioned this issue Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants