Threaded transfers loader #2917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GTK is single-threaded. You'd need to implement something like https://github.com/mathiascode/nicotine-plus/tree/async-rows instead, adding rows in batches (currently, only user browse works somewhat, but there are several edge cases you need to handle). |
Draft
|
Thank you I was confident that you would have a better suggestion like that, so I'd like us to work on #2952 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft concept to close #2910
On initial testing it doesn't appear to actually make any difference. I think Multiprocessing is needed?
Theoretically, this could be dangerous unless
self._allow_saving_transfersis used to block most functions.