Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad user experience with Windows-like buttons on Nicotine 3.3.0 #2880

Open
SnIPeRSnIPeR opened this issue Feb 15, 2024 · 16 comments
Open

Bad user experience with Windows-like buttons on Nicotine 3.3.0 #2880

SnIPeRSnIPeR opened this issue Feb 15, 2024 · 16 comments
Labels
Milestone

Comments

@SnIPeRSnIPeR
Copy link
Contributor

Nicotine+ version: 3.3.0
Operating System/Distribution: Windows 10 LTSC 2021 (21H2)

In new version of Nicotine+ I need to click twice on windows-like buttons (_ [] X) to start them working. Just try to open Settings, after that you cannot exit this tab clicking once on (X) button. This bug occurs wherever these buttons are.

@SnIPeRSnIPeR
Copy link
Contributor Author

3.3.2 same problem

@slook
Copy link
Member

slook commented Apr 4, 2024

And 3.3.3rc2 https://github.com/nicotine-plus/nicotine-plus/blob/master/doc/TESTING.md#windows ?

What is GTK version displayed in Menu > Help > About Nicotine+ dialog?

@SnIPeRSnIPeR
Copy link
Contributor Author

And 3.3.3rc2 https://github.com/nicotine-plus/nicotine-plus/blob/master/doc/TESTING.md#windows ?

What is GTK version displayed in Menu > Help > About Nicotine+ dialog?
Hmm, I haven't installed it yet...

3.3.2
GTK 4.12.5 • Python 3.11.8

@SnIPeRSnIPeR
Copy link
Contributor Author

Same problem with 3.3.3rc2. I need to hit twice on X buttons, when I want to exit Nicotine+, or exit from Settings tab in a program...

@mathiascode
Copy link
Member

Reported upstream: https://gitlab.gnome.org/GNOME/gtk/-/issues/6614

@slook
Copy link
Member

slook commented Apr 11, 2024

Upstream issue was just closed with https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7114

@mathiascode
Copy link
Member

Sorry, this missed the GTK 4.14.3 release. Might have to wait until Nicotine+ 3.3.4 for the fix.

@SnIPeRSnIPeR
Copy link
Contributor Author

SnIPeRSnIPeR commented Apr 20, 2024

Sorry, this missed the GTK 4.14.3 release. Might have to wait until Nicotine+ 3.3.4 for the fix.

So long time to wait...

@mathiascode
Copy link
Member

Looks like we have to wait for GTK 4.14.4 for a macOS fix: https://gitlab.gnome.org/GNOME/gtk/-/issues/6642

The Nicotine+ 3.3.3 release will be delayed until GTK 4.14.4 is released, but this issue should be fixed by then.

@mathiascode mathiascode added this to the 3.3.3 milestone Apr 21, 2024
@mathiascode
Copy link
Member

This is fixed now.

@mathiascode mathiascode reopened this May 6, 2024
@mathiascode mathiascode removed this from the 3.3.3 milestone May 6, 2024
@mathiascode
Copy link
Member

The fix had to be reverted when downgrading GTK 4 to fix #3000.

@SnIPeRSnIPeR
Copy link
Contributor Author

Some bad things appear on 3.3.4... When I close Statistics and make fast click on [X] to close app, the button doesn't work on first click.

@mathiascode
Copy link
Member

As I said above...

@SnIPeRSnIPeR
Copy link
Contributor Author

As I said above...

I don't see any of these problems in other apps on Windows :) It's not Windows, maybe GTK.

@mathiascode mathiascode added this to the 3.3.5 milestone May 10, 2024
@mathiascode
Copy link
Member

mathiascode commented May 10, 2024

I might have been unclear. The issue was fixed in GTK 4.14.4, but this version also had a regression in scrolling performance, which required us to temporarily downgrade to GTK 4.14.3.

GTK 4.14.5, which will be included in Nicotine+ 3.3.5, includes fixes for both issues.

Note that GTK 4.14.5 has not been released yet.

@SnIPeRSnIPeR
Copy link
Contributor Author

I might have been unclear. The issue was fixed in GTK 4.14.4, but this version also had a regression in scrolling performance, which required us to temporarily downgrade to GTK 4.14.3.

GTK 4.14.5, which will be included in Nicotine+ 3.3.5, includes fixes for both issues.

Note that GTK 4.14.5 has not been released yet.

Wow, true detective like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants