Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSURLQueryItem #11

Open
dpfannenstiel opened this issue Jan 29, 2016 · 1 comment
Open

NSURLQueryItem #11

dpfannenstiel opened this issue Jan 29, 2016 · 1 comment

Comments

@dpfannenstiel
Copy link

I saw that in write-your-own-api-clients-swift.md you're establishing parameters by using percent escapes. Consider modifying it to include NSURLQueryItem. It can reduce the cargo cult programming that a lot of developers (myself included) encounter when trying to format a URL.

@nickoneill
Copy link
Owner

Thanks for the suggestion @dpfannenstiel! I agree, NSURLQueryItem is probably the proper way to go about things. I'll look into adding it into the post - though it's really just a template for the client itself, the format for the request body will vary from provider to provider.

If you want to submit a PR with how you'd do it, I'd happily include it with attribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants