Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driveby-sharing: Chrome doesn't work on pure image files (jpg/png/...). #32

Open
seul opened this issue Jun 20, 2012 · 2 comments
Open
Assignees

Comments

@seul
Copy link
Collaborator

seul commented Jun 20, 2012

It doesn't work here: http://25.media.tumblr.com/tumblr_m5m5339Sga1qza249o1_400.jpg
And neither on some other jpg I tried
Nor on this .png: http://gritttt-rss.nicolashoening.de/style/logo.png

@seul
Copy link
Collaborator Author

seul commented Jun 20, 2012

How to reproduce:
In chromium

  • Go to one of the above links
  • click the drive by bookmarklet
  • Overlay doesn't show – no error, nothing.

@nhoening
Copy link
Owner

The line

head.appendChild(css);

throws this error:

Uncaught TypeError: Cannot call method 'appendChild' of undefined

Reason is tat there is no HTML structure in an image to append our CSS to. Firefox has an implicit HTML structure, it seems. I don't know how best fix this. At least we should check if head is defined, of course, but I am unsure if sharing images will work (nicely) on Chrome.

@ghost ghost assigned nhoening Jun 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants