Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitter TESTING Angular 10 Dependency Deprecated #542

Open
cavargas40 opened this issue Aug 31, 2020 · 0 comments
Open

Emitter TESTING Angular 10 Dependency Deprecated #542

cavargas40 opened this issue Aug 31, 2020 · 0 comments

Comments

@cavargas40
Copy link

cavargas40 commented Aug 31, 2020

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => https://github.com/ngxs/store/blob/master/CONTRIBUTING.md
[ ] Other... Please describe:

Current behavior

The emitter plugin TESTING is using a deprecated dependency with Angular 10.

Expected behavior

When I'm trying to use this plugin with Angular 10. I want to run tests without issues.

Minimal reproduction of the problem with instructions

When I'm using the out of the box solution for testing with the emitter. one of the dependencies. (ModuleWithProviders) now requires an argument. (The fix is quite small)...

In the file:
https://github.com/ngxs-labs/emitter/blob/master/emitter/testing/src/lib/store-test-bed.module.ts:10

should replace:
public static configureTestingModule(states: Type<any>[] = []): ModuleWithProviders[] {

with:

public static configureTestingModule(states: Type<any>[] = []): ModuleWithProviders<any>[] {

What is the motivation/use case for changing the behaviour?

Be able to run a test suit in Angular 10.

Environment


Libs:
- @angular/core version: 10.0.0
- @ngxs/store version: 3.6.2
- @ngxs-labs/emitter version: 2.0.0

For Tooling issues:
- Node version: v12.16.3
- Platform: Mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant