Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: remove base href override so that one build can be used for both cordova and web #433

Open
1 of 3 tasks
captaincaius opened this issue Jan 25, 2019 · 2 comments
Open
1 of 3 tasks
Labels

Comments

@captaincaius
Copy link
Contributor

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request

Current behavior

cordova builds use base href "./" and web builds use base href "/". I believe this was to work around a webview bug that's now been closed. I tested with an iPhone X and a Xiaomi android and it doesn't seem necessary anymore.

Expected behavior

base href="/" in all cases.

Minimal reproduction of the problem with instructions

Environment

- generator version: 6.x
- node version: 10.x  <!-- run `node --version` -->
- npm version: 6.x  <!-- run `npm --version` -->
- OS:  <!-- Mac, Linux, Windows -->

Others:

@sinedied
Copy link
Member

Does it work on iOS with ionic-webview-plugin and HTML5 routing enabled? (hashbang routing is forced on mobile if I remember well, because it led to routing issues)

If it works now everywhere, yes we should definitely update that! :)

@captaincaius
Copy link
Contributor Author

Hmm I didn't try hashbang routing, but on PathLocationStrategy it seems to work well. I guess it might be safer to try this after the CI app builds are all set up so I don't break something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants