Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: more sample code for theming material #420

Open
1 of 3 tasks
captaincaius opened this issue Dec 15, 2018 · 2 comments
Open
1 of 3 tasks

feature: more sample code for theming material #420

captaincaius opened this issue Dec 15, 2018 · 2 comments
Labels

Comments

@captaincaius
Copy link
Contributor

I'm submitting a...

  • Bug report
  • Feature request
  • Documentation issue or request

Current behavior

Having just gone through a big port to material, I thought it might be good to have some commented code come out of the app generator for the following:

  • secondary themes (e.g. a dark theme)
  • individual theme variable overrides (e.g. for background)
  • individual component overrides (e.g. you want to override the toolbar w.r.t. the default)

LMK if it's a welcome addition, and if so, for which branch.

Expected behavior

Minimal reproduction of the problem with instructions

Environment

- generator version: X.Y.Z
- node version: X.Y.Z  <!-- run `node --version` -->
- npm version: X.Y.Z  <!-- run `npm --version` -->
- OS:  <!-- Mac, Linux, Windows -->

Others:

@Viatorus
Copy link

Viatorus commented Mar 7, 2019

Hey, I currently stuck on:

individual component overrides (e.g. you want to override the toolbar w.r.t. the default)

I have a component (like about.component) which should have an extra icon in the header.
What would be the best way of doing this? Just adding the icon to header.component seems totally wrong.

@sinedied
Copy link
Member

Sorry for the long delay, this is for sure a welcome addition :) I can be done on a separate branch starting from v6 release as it will (hopefully) merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants