Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rbac ServiceAccount imagePullSecrets template #1953

Merged
merged 2 commits into from May 14, 2024

Conversation

bjee19
Copy link
Contributor

@bjee19 bjee19 commented May 9, 2024

Fix rbac ServiceAccount imagePullSecrets template.

Problem: NGF fails to deploy with NGINX+ because of the rbac ServiceAccount imagePullSecrets template error.

Solution: Fix the spacing which moves imagePullSecrets from being in the ServiceAccount's metadata to its own field.

Testing: Created Kubernetes secret and Docker Config Secret, then deployed NGF with NGINX+ and saw that the error was no longer there.

Closes #1952

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Fix rbac ServiceAccount imagePullSecrets template which caused errors when running NGF with NGINX+

@bjee19 bjee19 requested a review from a team as a code owner May 9, 2024 21:20
@github-actions github-actions bot added bug Something isn't working helm-chart Relates to helm chart labels May 9, 2024
@bjee19 bjee19 force-pushed the fix/image-pull-secrets-rbac-template branch from 55cf923 to dff216a Compare May 14, 2024 17:23
@bjee19 bjee19 merged commit e1c480c into nginxinc:main May 14, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm-chart Relates to helm chart release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

NGF with NGINX+ fails to deploy because of imagePullSecrets template error
3 participants