Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPCRouteFilter Request HTTPHeaderFilter for GRPCRouteRule #1766

Closed
Tracked by #1139
mpstefan opened this issue Mar 25, 2024 · 3 comments · Fixed by #1909
Closed
Tracked by #1139

GRPCRouteFilter Request HTTPHeaderFilter for GRPCRouteRule #1766

mpstefan opened this issue Mar 25, 2024 · 3 comments · Fixed by #1909
Assignees
@ciarams87
Labels
area/grpcroute/core Releates to all core features of GRPCRoute enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Milestone
v1.3.0

Comments

@mpstefan
Copy link
Collaborator

mpstefan commented Mar 25, 2024 •
edited

As a user of NGF with applications that require GRPC traffic
I want NGF to support a GRPCRouteRule that can handle a request HTTPHeaderFilter
So that I can append specific headers required by my applications.

Acceptance

  • A user can specify a GRPCRouteFilter in their GRPC routes.
  • The GRPCRouteFilter can be of type "RequestHeaderModifier" as defined here.
  • A user can specify a request HTTPHeaderFilter in their GRPCRouteFilter which works as specified here.
@mpstefan mpstefan mentioned this issue Mar 25, 2024
Open
@mpstefan mpstefan changed the title GRPCRoute Header Matching GRPCRoute Request Header Matching Apr 1, 2024
@mpstefan mpstefan changed the title GRPCRoute Request Header Matching GRPCRoute Request HTTPHeaderFilter Apr 1, 2024
@mpstefan mpstefan added enhancement New feature or request area/grpcroute/core Releates to all core features of GRPCRoute labels Apr 1, 2024
@mpstefan
Copy link
Collaborator Author

mpstefan commented Apr 1, 2024 •
edited

Can we leverage the existing HTTPHeaderFilter for HTTPRouteFilters here?

responseHeaderModifier is marked as Extended in the GRPCRouteFilter, but Core in the GRPCRouteFilter types. Do we implement?

@mpstefan mpstefan added this to the v1.3.0 milestone Apr 1, 2024
@mpstefan mpstefan changed the title GRPCRoute Request HTTPHeaderFilter GRPCRouteFilter Request HTTPHeaderFilter Apr 1, 2024
@mpstefan mpstefan changed the title GRPCRouteFilter Request HTTPHeaderFilter GRPCRouteFilter Request HTTPHeaderFilter for GRPCRouteRule Apr 1, 2024
@mpstefan mpstefan added refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days labels Apr 17, 2024
@mpstefan mpstefan mentioned this issue Apr 18, 2024
Closed
@ciarams87 ciarams87 self-assigned this Apr 24, 2024
@ciarams87
Copy link
Member

@mpstefan I'm going to address requestHeaderModifier only as part of this ticket, as support for responseHeaderModifier for HTTPRoute (which 95% covers the support for GRPCRoute) is already covered in #1397. I think that ticket can probably be used to track responseHeaderModifier filter support for both Route types (or maybe another ticket would be better, but if so, #1397 should still go first).

@ciarams87 ciarams87 mentioned this issue Apr 30, 2024
Merged
6 tasks
@mpstefan
Copy link
Collaborator Author

mpstefan commented May 2, 2024

Sounds good! Glad we can reuse #1397 here.

@sjberman sjberman mentioned this issue May 6, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciarams87 ciarams87

Labels
area/grpcroute/core Releates to all core features of GRPCRoute enhancement New feature or request refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

Add request header filter support for gRPC ciarams87/nginx-gateway-fabric
2 participants
@mpstefan @ciarams87