Add field to NginxProxy to allow disabling HTTP2 #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 86.90% 86.96% +0.05%
==========================================
Files 88 89 +1
Lines 6056 6083 +27
Branches 50 50
==========================================
+ Hits 5263 5290 +27
Misses 741 741
Partials 52 52 ☔ View full report in Codecov by Sentry. |
ciarams87
commented
May 2, 2024
ciarams87
force-pushed
the
feat/add-disable-http2-option
branch
3 times, most recently
from
5abffd1
to
dc4828e
Compare
sjberman
reviewed
May 15, 2024
sjberman
approved these changes
May 15, 2024
ciarams87
changed the title
ciarams87
changed the title
ciarams87
force-pushed
the
feat/add-disable-http2-option
branch
from
3b07215
to
8ba7bb1
Compare
pleshakov
reviewed
May 16, 2024
ciarams87
force-pushed
the
feat/add-disable-http2-option
branch
from
8ba7bb1
to
9e09fbd
Compare
kate-osborn
approved these changes
May 16, 2024
pleshakov
approved these changes
May 16, 2024
Co-authored-by: Saylor Berman <s.berman@f5.com>
ciarams87
force-pushed
the
feat/add-disable-http2-option
branch
from
9e09fbd
to
1e02137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: We need a way to allow a user to disable HTTP2
Solution: Extend the NginxProxy CRD to include a DisableHTTP2 option which will apply to all servers
Testing: Unit and local testing, confirmed that the http2 directive is set correctly unless disabled. If disabled, confirmed that a condition is added to any GRPCRoutes.
Closes #1858
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.