Should nginx.tmpl's https_method=redirect block try to include vhost.d files? #1613
Comments
Adds customization points to https redirect responses that are analagous to other response handling. This gives you the opportunity to add response headers or etc. before returning the 301 redirect. If `$host` or `default` exist in `/etc/nginx/vhost.d/`, we rely on nginx-proxy/acme-companion to add the Let's Encrypt acme challenge location block there, so it's only included here if those files don't exist. Fixes nginx-proxy#1613
|
See this change for what I think may be the correct behavior. I'm still working to get the desired effect, and it needs some tests. Edit: @buchdag that change relies on nginx-proxy/acme-companion to add the location block to vhost files. Is that reasonable or not really possible here (in this repo)? You may not want to assume that users have that set up, but I don't think there's a clean way to check whether the location block exists in a vhost file we can include. |
Adds customization points to https redirect responses that are analagous to other response handling. This gives you the opportunity to add response headers or etc. before returning the 301 redirect. If `$host` or `default` exist in `/etc/nginx/vhost.d/`, we rely on nginx-proxy/acme-companion to add the Let's Encrypt acme challenge location block there, so it's only included here if those files don't exist. New tests in `test_ssl` are similar to tests in `test_custom`, except they expect 301 responses along with custom configs. Fixes nginx-proxy#1613
Adds customization points to https redirect responses that are analogous to other response handling. This gives you the opportunity to add response headers or etc. before returning the 301 redirect. If `$host` or `default` exist in `/etc/nginx/vhost.d/`, we rely on nginx-proxy/acme-companion to add the Let's Encrypt acme challenge location block there, so it's only included here if those files don't exist. New tests in `test_ssl` are similar to tests in `test_custom`, except they expect 301 responses along with custom configs. Fixes nginx-proxy#1613
That's intersecting with something I had in mind for a while. nginx-proxy should be able to detect if the acme-companion is in use for a specific container and automatically add the |
buchdag
added
kind/feature-request
|
Do you have a way of detecting that in mind? I could add it to #1618 if you let me know how you'd like to go about it. I haven't looked in to how to do that yet but it was on my list of things to try. |
Adds customization points to https redirect responses that are analogous to other response handling. This gives you the opportunity to add response headers or etc. before returning the 301 redirect. If `$host` or `default` exist in `/etc/nginx/vhost.d/`, we rely on nginx-proxy/acme-companion to add the Let's Encrypt acme challenge location block there, so it's only included here if those files don't exist. New tests in `test_ssl` are similar to tests in `test_custom`, except they expect 301 responses along with custom configs. Fixes nginx-proxy#1613
I'm trying to add a header to all possible responses (disabling FLoC), and I can't gracefully add it for the default https redirects.
For other (
www.domain.com>domain.com) redirects, adding the header in the appropriatevhost.dworks correctly with theirreturn 301s.It seems like it may work if
vhost.dincludes are added somewhere around nginx.tmpl#L266.Thoughts?
The text was updated successfully, but these errors were encountered: