Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the icons changeable #2354

Open
oividioscaeremos opened this issue Mar 5, 2024 · 4 comments
Open

Make the icons changeable #2354

oividioscaeremos opened this issue Mar 5, 2024 · 4 comments
Assignees

Comments

@oividioscaeremos
Copy link

Is your feature request related to a problem? Please describe.
Currently, the clear icon is literally the letter x with some styling going on around it.

Describe the solution you'd like
I would like to have an option to change the clear icon. At the very least, there shouldn't be a literal character there that makes it very hard to change. (I had to clear the letter x and then style a custom icon via JS and not a big fan of this solution since it requires a re-do every time the clear icon is clicked on and some value is entered.)

Changing the dropdown icon was also tricky, so if both are re-designed to get changed via an <ng-content> it would be good.

Describe alternatives you've considered
I described above how I overcame this issue.

Additional context
image

@abdallahmmu
Copy link

can I work on this ?

@pavankjadda
Copy link
Collaborator

can I work on this ?

Sure

@abdallahmmu
Copy link

@pavankjadda any idea about how to install , the contribute file have no information about how to contribute and also i am facing problem with node-sass to install, trying to downgrade my node version 2 times but still not working .

@pavankjadda
Copy link
Collaborator

@abdallahmmu

  1. fork the repo
  2. Do yarn install
  3. make changes and create PR against this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants