Reflect model value changes with editableSearchTerm enabled #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows that the input value displayed in the component does not reflect changes to the model value.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2179 by updating the search term displayed in the input element when the model value changes. Includes a failing test as the first commit to demonstrate the problem and the solution.
When
editableSearchTermis enabled, the input is displayed instead of.ng-value-label. While the latter updated in response to model value updates, the former did not.As a consequence, changes to the model value while you are typing would be disruptive. I feel like this could be a contentious decision, but I chose to skip the search term update when the dropdown is open because I don't think we have a good distinction available for "is typing."
It would be wonderful if this could be hotfixed for earlier versions; I'm using 10.x which is also the version used in the stackblitz example on #2179.