Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnsl dependency #254

Open
ptsneves opened this issue Aug 30, 2022 · 6 comments · May be fixed by #255
Open

libnsl dependency #254

ptsneves opened this issue Aug 30, 2022 · 6 comments · May be fixed by #255

Comments

@ptsneves
Copy link

ptsneves commented Aug 30, 2022

Hello
I am trying to build ntirpc without libnsl2 in linux (non BSD). The reason I would like it to be possible is because libnsl2 in turn depends on a RPC implementation thus creating a circular dependency. Do you know if it is possible to build ntirpc without libnsl2?

@dang
Copy link

dang commented Aug 31, 2022

I haven't tried running it, but it builds fine if you comment out the nsl bits in CMakeLists.txt

@ptsneves
Copy link
Author

So do you think the requirement is obsolete?

@dang
Copy link

dang commented Sep 1, 2022

I take it back, it built because I have libnsl installed. libnsl provides NIS/YP, and this is used in ntirpc in several places, so it is, indeed, necessary.

@ffilz
Copy link
Member

ffilz commented Sep 1, 2022

Is there any way we can make libnsl optional for installations that don't use NIS/YP?

@ptsneves
Copy link
Author

ptsneves commented Sep 5, 2022

I removed the libnsl detection from CMakesLists and i was able to build. I cross compiled as an easy way to make sure my machine did not contaminate the build.

I searched for inclusion of headers from libnsl and

git grep -l rpcsvc
cmake/modules/FindNSL.cmake
man/publickey.3t
src/getpublickey.c
src/getrpcent.c
src/netname.c
src/netnamer.c

But from my compilation log some of these files are not compiled and the ones that are already have a #ifdef YP. So i guess we can just add the #ifdef YP to the remaining files just in case they are built in a configuration i maybe missing.

@ptsneves ptsneves linked a pull request Sep 7, 2022 that will close this issue
@ffilz
Copy link
Member

ffilz commented May 14, 2024

Patch submitted in pull request #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants