Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink Player Stats Logic #445

Open
mrcaseb opened this issue Nov 18, 2023 · 1 comment
Open

Rethink Player Stats Logic #445

mrcaseb opened this issue Nov 18, 2023 · 1 comment

Comments

@mrcaseb
Copy link
Member

mrcaseb commented Nov 18, 2023

We see new issues in #444 and already had lots of problems caused by the fact that we summarize play stats into a tidy form.

I think for player stats, we should make a transition to a new concept.

We load raw game data, extract the play stats and row bind them. This will make it pretty easy and straightforward to correctly summarize player stats and team stats.

@guga31bb
Copy link
Member

Yep this makes more sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants