Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cat_fastq? Sample with multiple run are not handled #148

Open
praveenraj2018 opened this issue Nov 10, 2022 · 2 comments
Open

No cat_fastq? Sample with multiple run are not handled #148

praveenraj2018 opened this issue Nov 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@praveenraj2018
Copy link

praveenraj2018 commented Nov 10, 2022

Description of the bug

Just noticed that when the pipeline is run with data from multiple libraries/runs, the pipeline produces results for each library/line separately which is a bit odd behavior. But you might know that such scenarios are handled in other pipelines such rnaseq and rnavar and even sarek.

Looks like the cat_fastq feature is not implemented in this pipeline.

Any specific reason for not including this feature?

Command used and terminal output

**Input sample_sheet.csv**


sample,fastq_1,fastq_2,seq_type
124127_265,/storage1/124127_265_S206_L002_R1_001.fastq.gz,/storage1/124127_265_S206_L002_R2_001.fastq.gz,rna
124127_265,/storage1/124127_265_S206_L003_R1_001.fastq.gz,/storage1/124127_265_S206_L003_R2_001.fastq.gz,rna
124127_265,/storage1/124127_265_S148_L004_R1_001.fastq.gz,/storage1/124127_265_S148_L004_R2_001.fastq.gz,rna
124127_265,/storage1/124127_265_S148_L003_R1_001.fastq.gz,/storage1/124127_265_S148_L003_R2_001.fastq.gz,rna

Output:

│   ├── 124127_265_T1
│   │   ├── 124127_265_T1_coverage_plot.pdf
│   │   └── 124127_265_T1_result.tsv
│   ├── 124127_265_T2
│   │   ├── 124127_265_T2_coverage_plot.pdf
│   │   └── 124127_265_T2_result.tsv
│   ├── 124127_265_T3
│   │   ├── 124127_265_T3_coverage_plot.pdf
│   │   └── 124127_265_T3_result.tsv
│   ├── 124127_265_T4
│   │   ├── 124127_265_T4_coverage_plot.pdf
│   │   └── 124127_265_T4_result.tsv


### Relevant files

_No response_

### System information

_No response_
@praveenraj2018 praveenraj2018 added the bug Something isn't working label Nov 10, 2022
@christopher-mohr
Copy link
Collaborator

Hi @praveenraj2018, thanks for reporting this. To me this is not a bug and expected behaviour for the HLA genotyping pipeline but of course it is worth discussing if that behaviour should be changed, also in order to make it more consistent with other nf-core pipelines.

@christopher-mohr christopher-mohr added enhancement New feature or request and removed bug Something isn't working labels Nov 18, 2022
@yunhua1031
Copy link

Hi @christopher-mohr, when will this enhancement be available? I'm also interested in using cat_fastq for hlatyping. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants