Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add list of webhooks to forum, stage, and voice channels #1177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add list of webhooks to forum, stage, and voice channels #1177

wants to merge 3 commits into from

Conversation

acco4321
Copy link
Contributor

@acco4321 acco4321 commented Apr 2, 2024

Summary

Adds .webhooks to ForumChannels, StageChannels, and VoiceChannels.

Resolves #1176

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

@EmreTech EmreTech added p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API labels May 18, 2024
EmreTech
EmreTech requested changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@EmreTech EmreTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise!

nextcord/channel.py

Requires :attr:`~.Permissions.manage_webhooks` permissions.

.. versionadded:: 2.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. versionadded:: 2.6
.. versionadded:: 3.0

nextcord/channel.py

Requires :attr:`~.Permissions.manage_webhooks` permissions.

.. versionadded:: 2.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. versionadded:: 2.6
.. versionadded:: 3.0

nextcord/channel.py

Requires :attr:`~.Permissions.manage_webhooks` permissions.

.. versionadded:: 2.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. versionadded:: 2.6
.. versionadded:: 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmreTech EmreTech EmreTech requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get webhooks in Forum, Stage, and Voice channels
2 participants
@acco4321 @EmreTech