Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a news topic via head line is partially not working #2497

Open
3 tasks done
derritter88 opened this issue Dec 14, 2023 · 5 comments
Open
3 tasks done

Opening a news topic via head line is partially not working #2497

derritter88 opened this issue Dec 14, 2023 · 5 comments
Labels
API Impact API/Backend code bug

Comments

@derritter88
Copy link
Contributor

derritter88 commented Dec 14, 2023

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

After installing 25.0.0-alpha2 I recognised that Heise articles can no longer be opened when clicking on the head line.
When hovering with my mouse pointer over the headline it wants to open heise.de but not the topic itself.

Screenshot 2023-12-14 084355

Currently it only works to get to the specific news article when there is a preview picture

Screenshot 2023-12-14 084511

For other RSS feed clicking on the headline to open the specific article still works.
This behaviour is also happening on my iPhone with "Nextnews" app.

Steps to Reproduce

Explain what you did to encounter the issue

  1. Have Heise.de RSS feed
  2. Click the headline

System Information

  • News app version: 25.0.0-alpha2
  • Nextcloud version: 28
  • Cron type: system
  • PHP version: 8.2-FPM
  • Database and version: Postgres 15
  • Browser and version: Firefox 120.0.1
  • OS and version: Win11 23H2
@stmichalke
Copy link

stmichalke commented Dec 14, 2023

There is an RSS feed as well which works as intended:
https://www.heise.de/rss/heise.rdf

The difference between the two feeds besides the first one being Atom (https://www.heise.de/rss/heise-atom.xml), the other one RSS, is that the Atom contains two link elements before the block of entries:
link rel="self"
link rel="alternate"
The href of the latter link is the same as the one of the headline.

@derritter88
Copy link
Contributor Author

Thanks - but this would be interessting as Heise articles previously worked well.

@Grotax
Copy link
Member

Grotax commented Dec 14, 2023

Noticed that too, seems to be a sidefect from the last feedio update. It contained a change regarding the urls, trying to fix relative links.

@Grotax
Copy link
Member

Grotax commented Dec 19, 2023

@IgorA100 could you maybe check this?

@Grotax Grotax added the API Impact API/Backend code label Dec 19, 2023
Grotax added a commit that referenced this issue Dec 24, 2023
Changed
- Changed default page when starting app (#2515)
- Downgrade feed-io to 5.3.1 (#2497)

Fixed
- Fix search support for Nextcloud 28 (#2432)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this issue Dec 24, 2023
Changed
- Changed default page when starting app (#2515)
- Downgrade feed-io to 5.3.1 (#2497)

Fixed
- Fix search support for Nextcloud 28 (#2432)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax
Copy link
Member

Grotax commented Dec 24, 2023

In the latest alpha I downgraded feed-io. Now the link is correct for new items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Impact API/Backend code bug
Projects
None yet
Development

No branches or pull requests

3 participants