Update feed favicons

[provokateurin]

The favicon of a feed is never updated after the feed was created. The favicon might change though, so it would be nice if the favicon link would be updated. Since the full feed is fetched anyway, we could just update the favicon link on the fly if we detect that it has changed.

[Grotax]

Hmm that is strange, the code was actually changed to pull the feed logo or as fallback the favicon on every update.

[provokateurin]

Hm I definitely have a feed where that doesn't work, there might be more. I realized this, because on my personal instance the feed has no icon, but on a test instance where I just added the feed it had an icon.

[Grotax]

Okay I think in that case you will have to check the logs, it is possible that for whatever reason the icon fetching does not work.

There should be an info log on errors and a debug log for more details.

I checked the code again and it does attempt to fetch the icon/logo every time.

[provokateurin]

Is there a way to trigger the refresh of all feeds via occ? Then I can turn on debug loggging and send you the logs.

[Grotax]

Yes per user, ./occ news:updater:update-user $userID

[deathbybandaid]

I'm migrating from Selfoss, and the first thing I noticed, is my feeds are all using website favicon instead of the icon tag.

My usecase is using Huginn to create custom RSS feeds for youtube channels, and using the API to get the video duration. All the other feed readers that I've used respect the icon tag for the feed.

For ease of use, I prefer the youtube channel logo's over Huginn's favicon :)

Nextcloud News:

Selfoss (and other feed readers):

[deathbybandaid]

For example, below is a slimmed down version of the feeds I generate (far superior to the one directly from youtube).
I've used these custom youtube feeders with several news aggregators, and not had issue. The above comment image with correct icon/image is pulled directly from Selfoss.

My only thought is Nextcloud News does not like image urls without a file extension.

<?xml version="1.0" encoding="UTF-8" ?>
<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/" xmlns:itunes="http://www.itunes.com/dtds/podcast-1.0.dtd">
<channel>
 <atom:link href="https://www.youtube.com/channel/UCXuqSBlHAE6Xw-yeJA0Tunw" rel="self" type="application/rss+xml" />
 <atom:icon>https://yt3.ggpht.com/ytc/AL5GRJXY8JLkAj-BGsEMUnMhblzkhBGAJYr8yid_b9jwZQ=s800-c-k-c0x00ffffff-no-rj</atom:icon>
 <itunes:image href="https://yt3.ggpht.com/ytc/AL5GRJXY8JLkAj-BGsEMUnMhblzkhBGAJYr8yid_b9jwZQ=s800-c-k-c0x00ffffff-no-rj" />

 <title>Linus Tech Tips</title>
 <description>Looking for a Tech YouTuber?

Linus Tech Tips is a passionate team of "professionally curious" experts in consumer technology and video production which aims to inform and educate people of all ages through our entertaining videos. We create product reviews, step-by-step computer build guides, and a variety of other tech-focused content.

Schedule:
New videos every Saturday to Thursday @ 10:00am Pacific
Live WAN Show podcasts every Friday @ ~5:00pm Pacific

</description>
 <link>https://www.youtube.com/channel/UCXuqSBlHAE6Xw-yeJA0Tunw</link>
 <lastBuildDate>Sun, 01 Oct 2023 12:48:04 -0400</lastBuildDate>
 <pubDate>Sun, 01 Oct 2023 12:48:04 -0400</pubDate>
 <ttl>5</ttl>
 <item>
  <title>Linus Tech Tips | WAN: GO Is Gone Forever - WAN Show September 29, 2023 | 2023-09-29 20:14 EDT |  Livestream</title>
  <link>https://www.youtube.com/watch?v=yFujQ4xvi9o</link>
  <description>&lt;a href="https://www.youtube.com/watch?v=yFujQ4xvi9o"&gt;&lt;img alt="Youtube" src="https://i.ytimg.com/vi/yFujQ4xvi9o/maxresdefault_live.jpg"&gt;&lt;/a&gt;&lt;br&gt;&lt;/p&gt;Check out SignalWire at: https://bit.ly/signalwirewan
Unify and simplify your PC components! Check out Corsair’s iCUE Link Smart Ecosystem at https://lmg.gg/CorsairiCUELink
Edit and Convert PDF with UPDF, Get 58% Off: https://bit.ly/3Zxl30s

Podcast download: TBD
Timestamps: TBD&lt;/p&gt;</description>
  <pubDate>Fri, 29 Sep 2023 20:14:45 -0400</pubDate>
  <id>yFujQ4xvi9o</id>
  <epoch>1696032885</epoch>
  <guid isPermaLink="false">1444364</guid>
 </item>
 <item>
  <title>Linus Tech Tips | I’m Staying on AMD! | 2023-09-28 13:00 EDT | 17M 32S</title>
  <link>https://www.youtube.com/watch?v=4yUMOK9dOQc</link>
  <description>&lt;a href="https://www.youtube.com/watch?v=4yUMOK9dOQc"&gt;&lt;img alt="Youtube" src="https://i.ytimg.com/vi/4yUMOK9dOQc/maxresdefault.jpg"&gt;&lt;/a&gt;&lt;br&gt;&lt;/p&gt;To learn more about the reliability and lack of operating sound on Seasonic's PSU's, check out: https://lmg.gg/ZP4sm

Back in March Luke, Jake, and myself all switched over to AMD to test our resolve after renouncing Nvidia. So are we sticking with AMD, or did we going crawling back to the 40 series?

Discuss on the forum: https://linustechtips.com/topic/1533428-i%E2%80%99m-staying-on-amd/

Buy a PowerColor Red Devil AMD Radeon RX 7900 XTX Graphics Card: https://geni.us/mDl4bq8
Buy a Seasonic Prime TX-1000 80+ Titanium PSU: https://geni.us/w5pR4
Buy an XFX Speedster MERC310 AMD Radeon RX 7900XT Graphics Card: https://geni.us/muzK78
Buy a Seasonic Prime TX-850 80+ Titanium PSU: https://geni.us/B5CJz1
Buy a PowerColor Red Devil AMD Radeon RX 6950 XT Graphics Card: https://geni.us/gC3cd0
Buy a Seasonic Focus GX-850 80+ Gold PSU: https://geni.us/JUGwV9
Buy an XFX Speedster SWFT309 AMD Radeon RX 6700 XT Graphics Card: https://geni.us/yiueR
Buy a Seasonic Focus GX-750 80+ Gold PSU: https://geni.us/O6Taa

Purchases made through some store links may provide some compensation to Linus Media Group.

► GET MERCH: https://lttstore.com
► GET EXCLUSIVE CONTENT ON FLOATPLANE: https://lmg.gg/lttfloatplane
► SPONSORS, AFFILIATES, AND PARTNERS: https://lmg.gg/partners
► EQUIPMENT WE USE TO FILM LTT: https://lmg.gg/LTTEquipment
► OUR WAN PODCAST GEAR: https://lmg.gg/wanset

FOLLOW US 
---------------------------------------------------  
Twitter: https://twitter.com/linustech
Facebook: http://www.facebook.com/LinusTech
Instagram: https://www.instagram.com/linustech
TikTok: https://www.tiktok.com/@linustech
Twitch: https://www.twitch.tv/linustech

MUSIC CREDIT
---------------------------------------------------
Intro: Laszlo - Supernova
Video Link: https://www.youtube.com/watch?v=PKfxmFU3lWY
iTunes Download Link: https://itunes.apple.com/us/album/supernova/id936805712
Artist Link: https://soundcloud.com/laszlomusic

Outro: Approaching Nirvana - Sugar High
Video Link: https://www.youtube.com/watch?v=ngsGBSCDwcI
Listen on Spotify: http://spoti.fi/UxWkUw
Artist Link: http://www.youtube.com/approachingnirvana

Intro animation by MBarek Abdelwassaa https://www.instagram.com/mbarek_abdel/
Monitor And Keyboard by vadimmihalkevich / CC BY 4.0  https://geni.us/PgGWp
Mechanical RGB Keyboard by BigBrotherECE / CC BY 4.0 https://geni.us/mj6pHk4
Mouse Gamer free Model By Oscar Creativo / CC BY 4.0 https://geni.us/Ps3XfE

CHAPTERS
---------------------------------------------------
0:00 Intro
1:10 (Linus') Bugs and Remote Play 
4:20 Linus' Final Thoughts
5:00 Luke's Crashes and Solutions
6:04 Performance and Framerates
7:45 Luke decides to...wait what?
10:04 Could the Cards Use More Time?
10:56 Jake's Initial Thoughts
13:09 Idle Power Draw
13:48 Jake's Final Thoughts
14:44 A Mixed Bag
16:17 Some Excellent Advice&lt;/p&gt;</description>
  <pubDate>Thu, 28 Sep 2023 13:00:48 -0400</pubDate>
  <id>4yUMOK9dOQc</id>
  <epoch>1695920448</epoch>
  <guid isPermaLink="false">1443433</guid>
 </item>
</channel>
</rss>

[Grotax]

I see, then you can try to debug it set loglevel to debug and check logs after feed update you can trigger an update with cli

[deathbybandaid]

Still parsing the debug logs, trying to make sense of what I'm looking at.
So far, it seems that Nextcloud News is looking at the image tag for the feeds that have the correct logo, but not the icon tag.

[deathbybandaid]

I found a feed produced by rss-bridge that utilizes the icon and logo tags for feeds

  <icon>https://hub.docker.com/favicon.ico</icon>
  <logo>https://hub.docker.com/favicon.ico</logo>

However the Huginn RSS output looks like it uses atom:icon and itunes:image

 <atom:icon>https://yt3.ggpht.com/ytc/AL5GRJXY8JLkAj-BGsEMUnMhblzkhBGAJYr8yid_b9jwZQ=s800-c-k-c0x00ffffff-no-rj</atom:icon>
 <itunes:image href="https://yt3.ggpht.com/ytc/AL5GRJXY8JLkAj-BGsEMUnMhblzkhBGAJYr8yid_b9jwZQ=s800-c-k-c0x00ffffff-no-rj" />

I'm looking at various feeds, and it seems that the "standard" for this feed logo/icon/image is all over the place!

[Grotax]

That is normal for rss and atom, almost no one fully follows the standard and many do completely strange stuff.

I think a fix for this, also checking other common fields would be best integrated in the feed-reader lib that we use: feed-io