Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Update video.js to latest version #11

Closed
naclander opened this issue Dec 2, 2016 · 8 comments
Closed

Update video.js to latest version #11

naclander opened this issue Dec 2, 2016 · 8 comments

Comments

@naclander
Copy link

naclander commented Dec 2, 2016

The latest version of video.js is 5.13.2, and it seems we are using an arbitrarily older version ( 4.12.11 )

I am wondering if a) there is a specific reason we are using such an old version and b) is there a plan to update video.js to the latest version

@Instagit
Copy link

Instagit commented Dec 4, 2016

The skin, which I think was an important reason to make the switch to this player, is not compatible with the latest video.js version. There's a link to an adjusted version, but that would also need some work as it still has some issues.

@Instagit
Copy link

I'm looking to replace Video.js with MediaElement.js, which now has better default functionality. 👉 #20

@jancborchardt
Copy link
Member

@Instagit just make sure that the project is active and properly maintained, and also compatible with all the relevant media file types which worked before. :)

@Instagit
Copy link

Instagit commented Apr 27, 2017

@jancborchardt Yeah, of course. I'm looking to make this a general improvement. Breaking working features is not acceptable. ;)

@jancborchardt
Copy link
Member

So in any case, let’s postpone this to Nextcloud 13 as we are in feature freeze. :) As soon as Nextcloud 12 is released we can experiment here.

@jancborchardt jancborchardt added this to the Nextcloud 13 milestone Apr 27, 2017
@naclander
Copy link
Author

Hey @Instagit ,

Why was this issue closed? We're still on the same version of video.js no?

@Instagit Instagit reopened this May 29, 2017
@Instagit
Copy link

@naclander
Sorry, I missed that this was added as a milestone. It would make more sense to add #20 instead as that's what we were referring to.

Updating Video.js, i.e. this issue, probably won't be solved as it's pointless to invest work in fixing all the CSS for the new Video.js version when we're looking to use another player in the future.

@naclander
Copy link
Author

@Instagit Makes sense, thanks for the reply.

@MorrisJobke MorrisJobke removed this from the Nextcloud 13 milestone Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants