Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Exemplar support #95

Open
gbracha opened this issue Jun 11, 2021 · 4 comments
Open

Complete Exemplar support #95

gbracha opened this issue Jun 11, 2021 · 4 comments

Comments

@gbracha
Copy link
Member

gbracha commented Jun 11, 2021

Class presenters now support exemplars, but we need to:

a. Add metadata for most classes.
b. Automatically generate exemplars for classes with unary factory selectors.
c. Add exemplar support for methods.

@gbracha
Copy link
Member Author

gbracha commented Jun 13, 2021

Item (b) above, "Automatically generate exemplars for classes with unary factory selectors." fixed in bceb556

@gbracha
Copy link
Member Author

gbracha commented Jul 4, 2021

Added support for (c) above, methods now use exemplar data to enable debugger entry. A lot more UI polish needed, as well as more metadata, and automatic generation of exemplars in unary methods, and in other contexts where we have an exemplar, for example in an arbitrary object inspector.

@gbracha
Copy link
Member Author

gbracha commented Jul 24, 2021

WIP. Exemplar methods allow evaluation in the method body. However, live evaluation is broken. In assorted method presenters (such as search results, or senders/implementers) eval results are not displayed.

@gbracha
Copy link
Member Author

gbracha commented Sep 15, 2021

Fixes ongoing. Exemplars mostly work, including in tests, search, sender/implementors. There are some bugs - for example, if we are deriving the exemplar by virtue of a surrounding object presenter, and not because we have either real exemplar metadata or a built-in rule for deriving an exemplar (e.g., unary factory, known factory selector etc.) then upon any model update we lose the evaluator display (but not the debug button). I believe I understand the cause, fixes will take a little longer.

Also, factory methods do not yet support exemplars. We really need to support separate metadata for calling the factory and for creating an instance in cases where exemplar instances are not specified as factory calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant