Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative to flask-restful #4

Closed
adelavega opened this issue Aug 28, 2020 · 4 comments · Fixed by #9
Closed

Alternative to flask-restful #4

adelavega opened this issue Aug 28, 2020 · 4 comments · Fixed by #9

Comments

@adelavega
Copy link
Member

Looks like we're using flask-restful for setting up API routes.

The project is pretty dead, and doesn't actually create any swagger-docs.

In fact, the author of the project even suggests alternative, as he himself uses other projects: flask-restful/flask-restful#883

I say we abandon ship now, and get on something maintained, before we get in too deep. Even just using Flasks regular MethodView would work.
@adelavega adelavega changed the title Abandon flask-restful Alternative to flask-restful Aug 29, 2020
@tyarkoni
Copy link
Contributor

Sounds good!

@adelavega adelavega mentioned this issue Sep 3, 2020
Merged
@jorgebg2016
Copy link

The thing I have to do is crying right now, because I was using flask-restful to build my API project. We can not always smile...

@tyarkoni
Copy link
Contributor

On further investigation, this looks quite trivial. Connexion's Resolver is compatible with MethodView (example here). So once we replace flask-restful's resourceful routing with MethodView, this is basically a drop-in replacement, and gives us all the benefits of connexion without having to do almost anything.

@adelavega
Copy link
Member Author

I already made the switch so it should be pretty easy

jdkent added a commit that referenced this issue Sep 20, 2022
@jdkent
attempt github registry cache #4
aa76f83
jdkent added a commit that referenced this issue Oct 4, 2022
@jdkent
[ENH] change workflow to incorporate data for frontend tests (#372)
a3dc440 
* tmp: matrix build

* test different build process

* change directories

* copy env file

* copy env file to different directory

* rename targets

* add workdir

* remove leading directories

* copy env file to correct folder

* explicit no build for docker-compose

* explictly state image name

* attempt github registry cache

* attempt github registry cache #2

* attempt github registry cache #3

* attempt github registry cache #4

* test reuse

* attempt to validate cache

* change nginx image names

* rename nginx and neurosynth

* keep service names in line

* fix name

* add inline cache argument

* remove inline cache argument

* set mode=max

* set set cache stage

* try #2

* empty cache

* test

* use different scopes

* parallelize frontend tests

* try to ingest data for cypress

* remove superfluous cp statement

* add more options to manage file

* fix cache name

* change default directories

* add 0T

* try to add working directory

* fix copy

* fix cache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop Flask-Restful neurostuff/neurostore
3 participants
@tyarkoni @adelavega @jorgebg2016