Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameters breaking tests / code #116

Open
strengejacke opened this issue Jan 15, 2021 · 1 comment
Open

parameters breaking tests / code #116

strengejacke opened this issue Jan 15, 2021 · 1 comment

Comments

@strengejacke
Copy link

Hi Dom,
here are the results from the failing revers dependency checks. I submitted parameters to CRAN, you may need to replace all instances from format_p() and use insight:: now...

New result: ERROR
    Runningtestthat.R’ [2s/2s]
  Running the tests intests/testthat.Rfailed.
  Complete output:
    > library(testthat)
    > library(psycho)
    Note: Many functions of the 'psycho' package have been (improved and) moved to other packages of the new 'easystats' collection (https://github.com/easystats). If you don't find where a function is gone, please open an issue at: https://github.com/easystats/easystats/issues
    > 
    > test_check("psycho")
    .0.00%
    .33.00%
    .67.00%
    .100.00%
    1
    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Error (test-assess.R:7:3): assess ───────────────────────────────────────────
    Error: 'format_p' is not an exported object from 'namespace:parameters'
    Backtrace:

     1. └─psycho::assess(...) test-assess.R:7:2
     2.   └─psycho::crawford.test(...)
     3.     └─base::paste0(...)
    ── Error (test-assess.R:42:3): crawford.test ───────────────────────────────────
    Error: 'format_p' is not an exported object from 'namespace:parameters'
    Backtrace:

     1. └─psycho::crawford.test(...) test-assess.R:42:2
     2.   └─base::paste0(...)
    ── Error (test-assess.R:97:3): crawford.test ───────────────────────────────────
    Error: 'format_p' is not an exported object from 'namespace:parameters'
    Backtrace:

     1. └─psycho::crawford_dissociation.test(...) test-assess.R:97:2
     2.   └─base::paste0(...)
    ── Error (test-assess.R:117:3): mellenbergh.test ───────────────────────────────
    Error: 'format_p' is not an exported object from 'namespace:parameters'
    Backtrace:

     1. └─psycho::mellenbergh.test(...) test-assess.R:117:2
     2.   └─base::paste0(...)
    
    [ FAIL 4 | WARN 0 | SKIP 0 | PASS 12 ]
    Error: Test failures
    Execution halted

I tell you once parameters is accepted on CRAN.

@DominiqueMakowski
Copy link
Member

thanks, I think I have fixed them, now just I need to iron out some other minor things before resubmitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants