Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eda_process: band, order, and frequency are hardcoded #98

Open
jdkent opened this issue Jul 10, 2019 · 0 comments · May be fixed by #99
Open

eda_process: band, order, and frequency are hardcoded #98

jdkent opened this issue Jul 10, 2019 · 0 comments · May be fixed by #99

Comments

@jdkent
Copy link

jdkent commented Jul 10, 2019

Thanks for making this awesome tool, I've recently found this and this will certainly make my life easier.

I have a request from my PI to do bandpass filtering, but with the current options this is unavailable.
I had a question about why band, order, and frequency were hard coded.
I can submit a pull request implementing this functionality if you are in support of adding this, or if you could provide a reason as to why this may be a bad idea (the hard coded numbers are necessary to be at those values) and I will try to communicate that to my PI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant