Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering for EDA #64

Open
Eichhof opened this issue Apr 26, 2018 · 3 comments
Open

Filtering for EDA #64

Eichhof opened this issue Apr 26, 2018 · 3 comments

Comments

@Eichhof
Copy link

Eichhof commented Apr 26, 2018

Hi

Before applying the cvxEDA algorithm you are filtering the signal. According to the cvxEDA paper this is not necessary: "As a result, the method does not require pre-processing of the observed SC signal (e.g., bandpass filtering) nor post-processing of the inferred phasic and tonic components (e.g., to deal with negative neural activations)."

@DominiqueMakowski
Copy link
Member

@Eichhof as you can turn off the cvxEDA algorithm, a bit of filtering is indeed done by default. I had some good results with it (mainly to clean some serious artifacts to ease the subsequent cvxEDA computation).

However, if you have reasons to think this could be a bad thing (the cvxEDA must be run on raw data), I believe we could either change it (and add the option to select between "traditional" filtering and cvxEDA) or a parameter to turn off the prefiltering.

What are your thoughts?

@Eichhof
Copy link
Author

Eichhof commented Apr 26, 2018

Actually, I have just seen that in eda_process() you pass the raw (unfiltered and unsmoothed) signal to cvxEDA. Am I right?

@DominiqueMakowski
Copy link
Member

Ah yes, I didn't remembered myself that this was already changed (I used the filtered signal at the beginning). Problem solved then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants