Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathLikeSelector.make_index() could be sped up by relying upon DataFrame.from_tuples() #15

Open
lebedov opened this issue Aug 15, 2014 · 1 comment

Comments

@lebedov
Copy link
Member

lebedov commented Aug 15, 2014

Since pandas.DataFrame.from_tuples() inserts NaN to fill in index rows for tuples that contain fewer elements than other tuples, we could rewrite make_index() to not explicitly extract levels from the expanded selector by relying upon from_tuples(); this might speed up the method. The presence of NaN values in the index shouldn't cause any problems.

@lebedov
Copy link
Member Author

lebedov commented Aug 18, 2014

Nikul noticed that the presence of NaNs in the index breaks selection with the DataFrame.ix attribute. We can still use from_tuples() when all of the rows are the same length, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant