Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH treeple tutorials should use native functions in scikit-tree #257

Open
sampan501 opened this issue Apr 17, 2024 · 3 comments
Open

ENH treeple tutorials should use native functions in scikit-tree #257

sampan501 opened this issue Apr 17, 2024 · 3 comments
Assignees

Comments

@sampan501
Copy link
Member

From #256:

We should fix the tutorials to use native functions in scikit-tree, like build_coleman_forest etc. It should be clear to the user that they don't need to write their own custom function to compute a p-value using MIGHT.

@PSSF23
Copy link
Member

PSSF23 commented Apr 18, 2024

Jovo wants to add a figure similar to this one, which would require all the intermediate statistics (the ones that 2 permuted forest make). build_coleman_forest doesn't return those values, unfortunately, so I'll postpone the conversion for now.

@sampan501
Copy link
Member Author

Sure, we could write it like this instead. Show all the intermediate stats figures, and at the end show how to compute the stat and p-value using treeple

@adam2392
Copy link
Collaborator

The statistics we need are the null distribution? What else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants