Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] G-KSG MI estimator #179

Closed
wants to merge 2 commits into from
Closed

[ENH] G-KSG MI estimator #179

wants to merge 2 commits into from

Conversation

SUKI-O
Copy link
Member

@SUKI-O SUKI-O commented Nov 30, 2023

Closes #162
Implement G-KSG MI estimator with UnsupervisedRandomForest class

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@SUKI-O SUKI-O linked an issue Nov 30, 2023 that may be closed by this pull request
Local determination of nearest-nbrs: MI/CMI forest estimators with G-KSG (geodesic distance using Unsupervised forest) and Local Permutation #162
Open
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9dcf913) 90.52% compared to head (8186cf7) 90.52%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files          48       48           
  Lines        4020     4020           
=======================================
  Hits         3639     3639           
  Misses        381      381

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SUKI-O SUKI-O requested a review from adam2392 December 2, 2023 16:25
adam2392
adam2392 reviewed Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plots could use some work. E.g. always label axes.

Few questions for you to explore:

  1. If you increase the sample sizes even further, does the estimate of G-KSG MI plateau?
  2. If instead you increase dimensionality with sample size fixed, what is the plot look like?
  3. If you repeat with different random seeds for each plot, this will provide some insight into the variance of this simulation.

@adam2392 adam2392 deleted the branch temp2 April 26, 2024 07:58
@adam2392 adam2392 closed this Apr 26, 2024
@adam2392
Copy link
Collaborator

Apologies! I messed up the main branch, and as a result this PR auto-closed. Do you mind resubmitting it if it's of interest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam2392 adam2392 adam2392 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@SUKI-O @adam2392