Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace kernel computation in kgof with hyppo's compute_kern #322

Open
darsh-patel opened this issue May 10, 2022 · 0 comments
Open

Replace kernel computation in kgof with hyppo's compute_kern #322

darsh-patel opened this issue May 10, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@darsh-patel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, the kernel goodness-of-fit library kgof has its own unique implementation of a kernel evaluation due to a unique data structure returned by autograd.numpy gradient calculations. This ArrayBox data structure does not share properties with numpy arrays and therefore must be handled separately and cannot be fed into compute_kern.

Describe the solution you'd like
Ideally, a new implementation would rip and replace kernel.py by removing its kernel evaluation functions and reducing the corresponding dependencies on autograd.numpy to do so. Should be a quick fix if handling of an ArrayBox can be improved or a better gradient calculation implementation is discovered.

Describe alternatives you've considered
There has already been an attempt to integrate compute_kern by replacing the eval functions in kernel.py with instances of compute_kern, but this raises an error in which values in an ArrayBox cannot be reached.

Additional context (e.g. screenshots)

@darsh-patel darsh-patel added the enhancement New feature or request label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant