Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kgof module #302

Open
darsh-patel opened this issue Feb 3, 2022 · 1 comment
Open

Refactor kgof module #302

darsh-patel opened this issue Feb 3, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request ndd Issues for NeuroData Design

Comments

@darsh-patel
Copy link
Contributor

darsh-patel commented Feb 3, 2022

Is your feature request related to a problem? Please describe.
The current state of the GoF Module is such that it takes a Data object wrapping a numpy array as input. For the module to match the remainder of the library, it needs to take numpy arrays as inputs. Additionally, new kernel support must be added to ensure the module covers a variety of different use cases.

Describe the solution you'd like

  • The FSSD class that inherits from the base class includes extraneous helper methods: Does not match the style of the child classes present in the rest of the library; There is a circular import involved if one attempts to remove the helper methods from the child class; Will require an in-depth rip-and-replace
  • Kgof currently takes inputs in the form of a Data object – an object encapsulating a 2-dimensional numpy array: The Data object also contains a synthetic “Datasource” that allows for a resampling of data; Does not match with the inputs for the remainder of the library
  • The module structure revolving around kernel sources and density sources contains code that is redundant with other things in hyppo: Remove this code and replace it with what has already been written

Describe alternatives you've considered

Additional context (e.g. screenshots)

@darsh-patel darsh-patel added the enhancement New feature or request label Feb 3, 2022
@darsh-patel
Copy link
Contributor Author

Please assign when you have a chance @sampan501

@sampan501 sampan501 added the ndd Issues for NeuroData Design label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ndd Issues for NeuroData Design
Projects
None yet
Development

No branches or pull requests

2 participants