Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test whether different types #246

Open
3 tasks
sampan501 opened this issue Dec 12, 2021 · 1 comment
Open
3 tasks

Test whether different types #246

sampan501 opened this issue Dec 12, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@sampan501
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently, methods in hyppo cast the input values to a float. While this is fine in most cases, it would be better to test if this restriction can be loosened to allow other types like int and see if the unit tests still pass.

Describe the solution you'd like

The solution has 3 steps:

Describe alternatives you've considered

Additional context (e.g. screenshots)

@sampan501
Copy link
Member Author

@darsh-patel This isn't enough for an NDD project. Didn't we talk last semester about cleaning up the goodness of fit module? And adding more tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant