Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NeuronTrace coordinate units more clear #358

Open
tathey1 opened this issue Jun 7, 2022 · 1 comment
Open

Make NeuronTrace coordinate units more clear #358

tathey1 opened this issue Jun 7, 2022 · 1 comment
Labels

Comments

@tathey1
Copy link
Member

tathey1 commented Jun 7, 2022

Neuron trace coordinates typically come in one of two coordinate systems: physical (e.g. microns) or voxel (e.g. coordinates relative to corner of image, in units of voxels). Cloudvolume handles this by giving skeleton objects an attribute called space which is either physical or voxel. This is a good model.

Our NeuronTrace object is a little messy when dealing with these coordinate systems. For example, the dataframe may be either physical or voxel coordinates, depending on if some seemingly unrelated argument rounding is True or false (see here). Let's make this more clear

@tathey1 tathey1 added the good first issue Good for newcomers label Dec 20, 2022
@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant