Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brainlit Documentation Fixes #250

Open
tathey1 opened this issue Mar 24, 2021 · 6 comments
Open

Brainlit Documentation Fixes #250

tathey1 opened this issue Mar 24, 2021 · 6 comments

Comments

@tathey1
Copy link
Member

tathey1 commented Mar 24, 2021

I'd like to start fixing the notebooks in our documentation page since many of them do not run. If we split the work it can be done faster. I think the below assignments make the most sense, but let me know if you have other ideas.

@bvarjavand :

  • utils
  • uploading_brains
  • downloading_brains

@shreyasingh1 : I know that you are still trying to figure out what's going on with the precomputed skeletons, but when you are able to fix things in these notebooks, please do.

  • downloading_benchmarking
  • uploading benchmarking

@alishakodibagkar : there are a couple more files I found that still rely on swc.py

  • pipelines/seg_pipeline_demo
  • viz/visualization
@tathey1
Copy link
Member Author

tathey1 commented Mar 24, 2021

Recall that you can build the documentation pages locally using docs/build_docs.sh then go to docs/html/index.html and open it. The notebooks are in the "tutorial" section.

Please develop according to the errors on your locally built docs. We are having issues with our environment building the docs on the web, apparently brainlit cannot be found e.g. see here. @bvarjavand not sure if you have any tips?

@bvarjavand
Copy link
Contributor

bvarjavand commented Mar 25, 2021

The python kernel that the notebooks are running do not have brainlit pip-installed. This is an issue with specifying the kernel of the notebook, see conf.py. I guess the "python3" kernel isn't the same as the system python3. Not sure exactly how to fix, but it would be there.

Nevermind, fixed by just pip installing brainlit via netlify.tml

@tathey1
Copy link
Member Author

tathey1 commented Mar 25, 2021

Let's have everyone fix their respective notebooks so the docs correctly build locally. Then PR into this branch.

At that point, I will need to fix some netlify things before we can PR all of our fixes into develop.

@tathey1
Copy link
Member Author

tathey1 commented Apr 6, 2021

I changed my mind, go ahead and just PR into the develop branch like Bijan did, I think PR'ing into my branch will be too complicated.

@tathey1
Copy link
Member Author

tathey1 commented Apr 28, 2021

Updates:

  • this PR makes the notebooks run now (although I am still trying to figure out how to get netlify to install brainlit). So, as I said above, please make your PR directly into develop.
  • this PR adds the updates to the utils notebooks from the bvarjavand-fixdocs branch. However, there is still an issue with downloading_brains notebook (I think credential related), so I requested @bvarjavand to review/fix that.

This was referenced May 5, 2021
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants