Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC fix typos & FIX modify python version for website builder #547

Open
wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

DOC fix typos & FIX modify python version for website builder #547

wants to merge 6 commits into from

Conversation

PSSF23
Copy link
Member

@PSSF23 PSSF23 commented Sep 6, 2022

Reference issue

Close #546
Close #543

Type of change

Documentation, Website

What does this implement/fix?

  • Fix attribute name typos
  • Modify website build python version

Additional information

@PSSF23 PSSF23 requested a review from jdey4 September 6, 2022 17:40
This was linked to issues Sep 6, 2022
DOC fix typos in model attribute titles #543
Open
FIX migrate Netlify image from Xenial to Focal #546
Open
PSSF23
PSSF23 commented Sep 7, 2022
View reviewed changes
Copy link
Member Author

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated test error: #548

@jdey4
Copy link
Member

jdey4 commented Sep 14, 2022

@PSSF23 what did you do about the MLKNN unit test?

@PSSF23
Copy link
Member Author

PSSF23 commented Sep 14, 2022

@PSSF23 what did you do about the MLKNN unit test?

Nothing. Unrelated.

@jdey4
Copy link
Member

jdey4 commented Sep 14, 2022

The unit tests seem to fail.

@PSSF23
Copy link
Member Author

PSSF23 commented Sep 14, 2022

The unit tests seem to fail.

Yes. But it's not related to this PR. I made another issue #548 for that.

@jdey4
Copy link
Member

jdey4 commented Sep 14, 2022

The unit tests seem to fail.

Yes. But it's not related to this PR. I made another issue #548 for that.

It's bad practice to merge PRs without all checks being passed! It will be better to possibly take out that unit test or use @pargma no cover to ignore the unit test.

PSSF23
PSSF23 commented Oct 6, 2022
View reviewed changes
Copy link
Member Author

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdey4 ignored the test for now.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 92.36% // Head: 88.54% // Decreases project coverage by -3.81% ⚠️

Coverage data is based on head (0d1a7cf) compared to base (af84f50).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff             @@
##           staging     #547      +/-   ##
===========================================
- Coverage    92.36%   88.54%   -3.82%     
===========================================
  Files            7        7              
  Lines          419      419              
===========================================
- Hits           387      371      -16     
- Misses          32       48      +16
Impacted Files Coverage Δ
proglearn/forest.py 100.00% <ø> (ø)
proglearn/network.py 100.00% <ø> (ø)
proglearn/progressive_learner.py 87.00% <ø> (ø)
proglearn/voters.py 74.71% <0.00%> (-18.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdey4 jdey4 Awaiting requested review from jdey4

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIX migrate Netlify image from Xenial to Focal DOC fix typos in model attribute titles
2 participants
@PSSF23 @jdey4